fix error if warning and/or critical not defined#26
Open
senorsmile wants to merge 1 commit intoc-kr:masterfrom
Open
fix error if warning and/or critical not defined#26senorsmile wants to merge 1 commit intoc-kr:masterfrom
senorsmile wants to merge 1 commit intoc-kr:masterfrom
Conversation
Since warning and critical are not required params, we should check to see if they are defined first before looping over them. Otherwise, we get an error in the output.
Author
|
I hadn't noticed, but someone has already reported this problem too: #22 |
C0rn3j
added a commit
to C0rn3j/check_json
that referenced
this pull request
Aug 26, 2020
linuxmail
pushed a commit
to linuxmail/check_json
that referenced
this pull request
Jan 11, 2022
0x446
pushed a commit
to 0x446/check_json
that referenced
this pull request
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since warning and critical are not required params, we should check to see if they are defined first before looping over them. Otherwise, we get an error in the output.