Complete the code test #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A) Describe the strategy used to consume the API endpoints and the data management. On the first screen I request the cocktail list. When a cocktail is selected I request the cocktail id endpoint. B) Explain which library was used for the routing and why. Would you use the same for a consumer facing app targeting thousands of users? Why? I'm using the navigation component provide from android C) Have you used any strategy to optimize the performance of the list generated for the first feature? No, but an optimization that could be done here is pagination if the API provides this feature. D) Would you like to add any further comments or observations? Yes, another optimitazion to the app could be done be spliting the api data model and the app data model. The api data model has a different fields for each ingredient and measure, so, those could be represented by a Ingredients object that containd the list of ingredient whit the measure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A) Describe the strategy used to consume the API endpoints and the data management.
On the first screen I request the cocktail list. When a cocktail is selected I request the cocktail id endpoint.
B) Explain which library was used for the routing and why. Would you use the same for a consumer facing app targeting thousands of users? Why?
I'm using the navigation component provide from android
C) Have you used any strategy to optimize the performance of the list generated for the first feature?
No, but an optimization that could be done here is pagination if the API provides this feature.
D) Would you like to add any further comments or observations?
Yes, another optimitazion to the app could be done be spliting the api data model and the app data model. The api data model has a different fields for each ingredient and measure, so, those could be represented by a Ingredients object that containd the list of ingredient whit the measure.