Fixes 3.0 install not actually installing anything #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
without this you get this issue where nothing actually happens on install
~/Repos/site$ ~/agent-os/scripts/project-install.sh
=== Agent OS Project Installation ===
The issue was a bash quirk:
((chain_depth++)) - post-increment returns the OLD value (0), which bash treats as "false" → exit code 1
((++chain_depth)) - pre-increment returns the NEW value (1), which bash treats as "true" → exit code 0
With set -e enabled, the script was dying on that line.
Configuration:
Linked item
Checklist
Documented steps to test
Notes for reviewers
thanks for all your great work