Skip to content

Conversation

@brignano
Copy link
Owner

Reverts #13

This pull request removes support for the resume.brignano.io subdomain and its associated DNS records from the Terraform infrastructure and documentation. The changes simplify the DNS setup by focusing only on the main domains and their www subdomains.

Infrastructure and DNS record updates:

  • Removed the resume.brignano.io CNAME DNS record resource from main.tf.
  • Removed the vercel_cname_record_resume local variable from locals.tf.

Documentation updates:

  • Updated iac/README.md to remove references to the resume subdomain and clarify the purpose of DNS management.
  • Updated readme.md to remove mention of the resume.brignano.io subdomain and clarify that only www subdomains are supported.

@github-actions
Copy link

Terraform Cloud Plan Output

Plan: 0 to add, 0 to change, 1 to destroy.

Terraform Cloud Plan

@brignano brignano marked this pull request as ready for review January 17, 2026 21:01
Copilot AI review requested due to automatic review settings January 17, 2026 21:01
@brignano brignano merged commit 634bc58 into main Jan 17, 2026
1 check passed
@brignano brignano deleted the revert-13-copilot/add-dns-record-for-resume branch January 17, 2026 21:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reverts PR #13, removing support for the resume.brignano.io subdomain from the infrastructure and documentation. The changes cleanly remove all DNS records and configuration related to the resume subdomain, simplifying the DNS setup to focus on the main domains and their www subdomains.

Changes:

  • Removed the resume.brignano.io DNS CNAME record from Terraform infrastructure
  • Removed the associated Vercel CNAME record variable from locals configuration
  • Updated documentation to reflect the removal of resume subdomain support

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
iac/main.tf Removed the aws_route53_record.resume resource that created the DNS CNAME record for resume.brignano.io
iac/locals.tf Removed the vercel_cname_record_resume local variable that was no longer needed
iac/README.md Updated DNS management documentation to remove references to the resume subdomain
readme.md Simplified domain management documentation to remove resume subdomain references and clarify www subdomain support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- www.brignano.io → Alias to brignano.io
- resume.brignano.io → Points to Vercel hosting (separate deployment)
- www.anthonybrignano.com → Points to Vercel hosting
- **WWW Redirect:** Both domains support www. subdomain
Copy link

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar issue: "Both domains support www. subdomain" should be either "Both domains support www subdomain" (without the period after www) or "Both domains support a www subdomain" for better readability.

Suggested change
- **WWW Redirect:** Both domains support www. subdomain
- **WWW Redirect:** Both domains support a www subdomain

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant