Skip to content

Add support for SSL verify_depth and verify_hostname options #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ag-TJNII wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for SSL verify_depth and verify_hostname options #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/persistent_http/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,20 @@ class Connection
# SSL verification callback. Used when ca_file is set.
attr_accessor :verify_callback

##
# HTTPS verify_depth
# Sets or returns the maximum depth for the certificate chain verification.
# https://github.com/ruby/ruby/blob/ruby_3_2/lib/net/http.rb#L1521-L1522
attr_accessor :verify_depth

##
# HTTPS verify_hostname
# Sets or returns whether to verify that the server certificate is valid
# for the hostname.
# See {OpenSSL::SSL::SSLContext#verify_hostname=}[rdoc-ref:OpenSSL::SSL::SSLContext#attribute-i-verify_mode].
# https://github.com/ruby/ruby/blob/ruby_3_2/lib/net/http.rb#L1529-L1532
attr_accessor :verify_hostname

##
# HTTPS verify mode. Defaults to OpenSSL::SSL::VERIFY_NONE which ignores
# certificate problems.
Expand Down Expand Up @@ -168,6 +182,8 @@ def initialize(options={})
@read_timeout = options[:read_timeout]
@use_ssl = options[:use_ssl]
@verify_callback = options[:verify_callback]
@verify_depth = options[:verify_depth]
@verify_hostname = options[:verify_hostname]
@verify_mode = options[:verify_mode]
@after_connect = options[:after_connect]
# Because maybe we want a non-persistent connection and are just using this for the proxy stuff
Expand Down Expand Up @@ -398,6 +414,8 @@ def ssl
end

@connection.verify_mode = @verify_mode if @verify_mode
@connection.verify_depth = @verify_depth if @verify_depth
@connection.verify_hostname = @verify_hostname unless @verify_hostname.nil? # This is a negative, false to turn off
end
end
end