Add missing map item on default layer 2 for Lulus#53
Open
mmdoogie wants to merge 1 commit intoboardsource:mainfrom
Open
Add missing map item on default layer 2 for Lulus#53mmdoogie wants to merge 1 commit intoboardsource:mainfrom
mmdoogie wants to merge 1 commit intoboardsource:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default main.py key maps when setting up Lulu boards are missing an item in the Layer 2 list (there's one less item in that row compared to all the other layers). This is what causes the weirdness from #20 and #34, which this should fix, for fresh setups at least. Perhaps in the main Peg code this situation could also be handled differently or at least detected with an error raised that could help people that already have the wrong line there, I'll try to look into that too probably when I get a chance.