Skip to content

When setting the font, the order can be reversed. Handle that situation #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbttfox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

When setting the font, the order can be reversed. Handle that situation #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion preditor/gui/loggerwindow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,13 @@ def selectFont(

# Present a QFontDialog for user to choose a font
title = "Pick a {} font. Current font is: {}".format(kind, curFontFamily)
newFont, okClicked = QFontDialog.getFont(origFont, self, title, options=options)
fontReturn = QFontDialog.getFont(origFont, self, title, options=options)

# QFontDialog.getFont returns a different order for Qt5 vs Qt6
if isinstance(fontReturn[0], bool):
okClicked, newFont = fontReturn
else:
newFont, okClicked = fontReturn

if okClicked:
if doGui:
Expand Down