ar: add a NewStrictReader #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This strict reader checks that the magic header is correct.
the size of the header
I've observed this happening.
chrisnovakovic
added a commit
to chrisnovakovic/ar
that referenced
this pull request
Oct 8, 2025
…h#14) The GNU variant of the ar format expects all real file names to have trailing slashes, regardless of whether they are stored in the string table or in the file name header field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NewReader method in reader.go doesn't check that the magic header is correct, this leads to some strange things, like ascii text files being parsed without any error.
This change is a suggestion to add a NewStrictReader which checks for the magic header.