feat: remove current story #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java-james
commented
Aug 15, 2025
| VerticalDragInfo? verticalDragInfo; | ||
|
|
||
| /// Removes the current story from the list and resets playback to the next story. | ||
| void removeCurrentStory() { |
Author
There was a problem hiding this comment.
New function here. All above in this file is just formatting changes.
Author
|
Refer to #191 for some ongoing discussion on the topic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the ability to remove the currently playing story.
Minor format changes to match formatter.
Approach
Add a new function to the controller that will remove the current story.
If it's the last story or the only story, call onComplete.
However, my use case assumes you navigate away / destroy the widget on completion. Therefore, the PR is more to open the conversation than a final solution suggestion.