Fix crash reported in issue #24. Change ringtone manager#25
Open
icc-guerrero wants to merge 8 commits intobkdev98:masterfrom
Open
Fix crash reported in issue #24. Change ringtone manager#25icc-guerrero wants to merge 8 commits intobkdev98:masterfrom
icc-guerrero wants to merge 8 commits intobkdev98:masterfrom
Conversation
Contributor
icc-guerrero
commented
Jun 8, 2021
icc-guerrero
commented
- RCT dismiss call crash fixed. Fixes Your new version crashed #24
- Use RingtoneManager instead of AudioManager for playing the ringtone. Calls use now ringtone volume instead of media volume. Avoid ring sound if the device is in silent / do not disturb mode.
Bugfix/ringing tone volume
pierguinzani
approved these changes
Mar 15, 2022
geraintwhite
pushed a commit
to geraintwhite/react-native-incoming-call
that referenced
this pull request
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.