Skip to content

Conversation

@coltonhurst
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30123

📔 Objective

The links go to the PO2 page, but they say PO1.

Screenshots

Broken Example

broken

Fixed Example

fixed

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst requested review from a team as code owners December 22, 2025 19:54
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc0af11ab-2866-4180-ab9a-a7b2a9c18ead

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new P01 stepped in and these were missed.

@coltonhurst coltonhurst merged commit c6a1193 into main Dec 22, 2025
19 checks passed
@coltonhurst coltonhurst deleted the autofill/pm-30123/fix-link-texts branch December 22, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants