ICalPreprocessor: more verbose logging #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the logging verbosity in ICalPreprocessor to make property transformations more visible during iCalendar preprocessing. The changes improve observability by logging the specific rule that modified a property and upgrading the log level from FINER to INFO.
Key changes:
- Upgraded log level from FINER to INFO for property transformation messages
- Added rule class name to log output for better debugging
- Removed unused
Levelimport
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/src/main/kotlin/at/bitfire/synctools/icalendar/validation/ICalPreprocessor.kt
Show resolved
Hide resolved
rfc2822
deleted the
161-icalpreprocessor-doesnt-log-which-rule-is-applied-when-changing-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log rule name when properties are changed (and increase log message importance)