This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Mahdiyeh/fix: remove symbol filtering in webtrader #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamali-fs
reviewed
Jul 19, 2021
src/common/util.js
Outdated
Comment on lines
1
to
3
| function filterRestrictedSymbols(active_symbols) { | ||
| return active_symbols.filter(function(item) { return !/^(BOOM|CRASH|STP).+/i.test(item.symbol)}); | ||
| return active_symbols; | ||
| } |
There was a problem hiding this comment.
Possible to remove the method and its usages across app?
Contributor
Author
There was a problem hiding this comment.
yes, since we do not need any symbol filtering we can remove the method, I will do it
matin-deriv
reviewed
Jul 19, 2021
src/instruments/instruments.es6
Outdated
Comment on lines
16
to
21
| const active_markets = _(data.active_symbols).groupBy('market').map(function(activeSymbols) { | ||
|
|
||
| const sym = _.head(activeSymbols); | ||
|
|
||
| const market = { name: sym.market, display_name: sym.market_display_name }; | ||
| market.submarkets = _(filtered_symbols).groupBy('submarket').map(function(symbols) { | ||
| market.submarkets = _(activeSymbols).groupBy('submarket').map(function(symbols) { |
Contributor
There was a problem hiding this comment.
Rename activeSymbols to a snake_case variable name
Contributor
Author
There was a problem hiding this comment.
we have active_symbols already, so I renamed it to all_symbols
src/trade/tradeMenu.es6
Outdated
Comment on lines
17
to
20
| let markets = _(data.active_symbols).groupBy('market').map((symbols) => { | ||
| const filtered_symbols = filterRestrictedSymbols(symbols); | ||
| const sym = _.head(filtered_symbols); | ||
| let markets = _(data.active_symbols).groupBy('market').map((activSymbols) => { | ||
| const sym = _.head(activSymbols); | ||
| const market = { name: sym.market, display_name: sym.market_display_name }; | ||
| market.submarkets = _(filtered_symbols).groupBy('submarket').map((symbols) => { | ||
| market.submarkets = _(activSymbols).groupBy('submarket').map((symbols) => { |
Contributor
There was a problem hiding this comment.
Rename to a snake_case variable name and fix the typo in word active
matin-deriv
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.