use meaurement_time instead of target_time in the warning message #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Bittencourt <fred.rbittencourt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while my benchmarks have been warning me the following:
When I finally decided to do something about it, I was surprised to see that there was no
target_timeproperty in the benchmark group. To no avail, I googled how to change "target time". I found #322 which didn't really fix my issue. It took me a while to figure out thattarget time == measurement time.This PR changes the warnings from
target->measurementto better match the name of the actual user facing config name.Seems like the warning was written like that because the name of the parameter in mode function (
iteration_counts) is calledtarget_time.Also threw an optional new snippet in the book which I missed when looking up how to change target time.