Skip to content

Fix CO2 sensor not appearing in HomeKit #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
350d wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix CO2 sensor not appearing in HomeKit #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d42e43c
fix: correct typo in CO2 sensor accessory class name - Fixed typo in …
350d Jun 3, 2025
be02b6f
fix: resolve CO2 sensor caching and variable scope issues - Fixed var…
350d Jun 4, 2025
662107d
fix: correct CO2 sensor accessory registration in index.js - Fixed ty…
350d Jun 4, 2025
fbf73e1
Update .gitignore
350d Jun 4, 2025
5221b3e
Update HttpWebHookCarbonDioxideSensorAccessory.js
350d Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@ package-lock.json
.cache
.idea
.DS_Store
/tmp
.cursor
*.icloud
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var HttpWebHookStatelessSwitchAccessory = require('./src/homekit/accessories/Htt
var HttpWebHookLockMechanismAccessory = require('./src/homekit/accessories/HttpWebHookLockMechanismAccessory');
var HttpWebHookWindowCoveringAccessory = require('./src/homekit/accessories/HttpWebHookWindowCoveringAccessory');
var HttpWebHookFanv2Accessory = require('./src/homekit/accessories/HttpWebHookFanv2Accessory');
var HttpWebHookCarbonDioxideSensoryAccessory = require('./src/homekit/accessories/HttpWebHookCarbonDioxideSensorAccessory');
var HttpWebHookCarbonDioxideSensorAccessory = require('./src/homekit/accessories/HttpWebHookCarbonDioxideSensorAccessory');
var HttpWebHookValveAccessory = require('./src/homekit/accessories/HttpWebHookValveAccessory');

module.exports = function(homebridge) {
Expand All @@ -30,6 +30,6 @@ module.exports = function(homebridge) {
homebridge.registerAccessory("homebridge-http-webhooks", "HttpWebHookLockMechanism", HttpWebHookLockMechanismAccessory);
homebridge.registerAccessory("homebridge-http-webhooks", "HttpWebHookWindowCovering", HttpWebHookWindowCoveringAccessory);
homebridge.registerAccessory("homebridge-http-webhooks", "HttpWebHookFanv2", HttpWebHookFanv2Accessory);
homebridge.registerAccessory("homebridge-http-webhooks", "HttpWebHookCarbonDioxideSensor", HttpWebHookCarbonDioxideSensoryAccessory);
homebridge.registerAccessory("homebridge-http-webhooks", "HttpWebHookCarbonDioxideSensor", HttpWebHookCarbonDioxideSensorAccessory);
homebridge.registerAccessory("homebridge-http-webhooks", "HttpWebHookValve", HttpWebHookValveAccessory);
};
4 changes: 2 additions & 2 deletions src/homekit/HttpWebHooksPlatform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var HttpWebHookStatelessSwitchAccessory = require('./accessories/HttpWebHookStat
var HttpWebHookLockMechanismAccessory = require('./accessories/HttpWebHookLockMechanismAccessory');
var HttpWebHookWindowCoveringAccessory = require('./accessories/HttpWebHookWindowCoveringAccessory');
var HttpWebHookFanv2Accessory = require('./accessories/HttpWebHookFanv2Accessory');
var HttpWebHookCarbonDioxideSensoryAccessory = require('./accessories/HttpWebHookCarbonDioxideSensorAccessory');
var HttpWebHookCarbonDioxideSensorAccessory = require('./accessories/HttpWebHookCarbonDioxideSensorAccessory');
var HttpWebHookValveAccessory = require('./accessories/HttpWebHookValveAccessory');

var Service, Characteristic;
Expand Down Expand Up @@ -118,7 +118,7 @@ HttpWebHooksPlatform.prototype.accessories = function(callback) {
}

for (var i = 0; i < this.co2sensors.length; i++) {
var co2sensorAccessory = new HttpWebHookCarbonDioxideSensoryAccessory(Service, Characteristic, this, this.co2sensors[i]);
var co2sensorAccessory = new HttpWebHookCarbonDioxideSensorAccessory(Service, Characteristic, this, this.co2sensors[i]);
accessories.push(co2sensorAccessory);
}

Expand Down
7 changes: 5 additions & 2 deletions src/homekit/accessories/HttpWebHookCarbonDioxideSensorAccessory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,18 @@ function HttpWebHookCarbonDioxideSensorAccessory(ServiceParam, CharacteristicPar
}

HttpWebHookCarbonDioxideSensorAccessory.prototype.changeFromServer = function(urlParams) {
var cached = this.storage.getItemSync("http-webhook-" + this.id) || 0;
var cached = this.storage.getItemSync("http-webhook-carbon-dioxide-level-" + this.id);
if (cached === undefined) {
cached = 0;
}
if (urlParams.value === undefined) {
this.log.debug(this.name + ": No urlValue");
return {
"success" : true,
"state" : cached
};
}
var urlValue = urlParams.value;
var urlValue = parseFloat(urlParams.value);
var co2Detected = urlValue > this.co2PeakLevel;
this.log.debug(this.name + ": urlValue: "+ urlValue);
this.log.debug(this.name + ": co2Detected: "+ co2Detected);
Expand Down