Skip to content

fix: adjust dithering canvas height #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weebao merged 1 commit into from
Jun 9, 2025
Merged

fix: adjust dithering canvas height #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
<ScrollUpButton screenWidth={1280} />
<div class="fixed -left-4 top-0 -z-[20] opacity-20">
<!-- Cool dithering Japanese effect -->
<div data-us-project="jzsvsRi2fATTRNcOAqWq" class="h-[calc(100dvh+4rem)] w-screen"></div>
<div data-us-project="jzsvsRi2fATTRNcOAqWq" class="h-[calc(100dvh+5rem)] w-screen"></div>
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment or extracting the '5rem' value to a constant to clarify the rationale behind this adjustment and facilitate future maintenance.

Suggested change
<div data-us-project="jzsvsRi2fATTRNcOAqWq" class="h-[calc(100dvh+5rem)] w-screen"></div>
<div data-us-project="jzsvsRi2fATTRNcOAqWq" class={`h-[calc(100dvh+${EXTRA_HEIGHT})] w-screen`}></div>

Copilot uses AI. Check for mistakes.
<script type="text/javascript">
!(function () {
if (!window.UnicornStudio) {
Expand Down