Skip to content

Conversation

@weebao
Copy link
Member

@weebao weebao commented Jun 9, 2025

yeah idk i was bored

Copilot AI review requested due to automatic review settings June 9, 2025 07:56
@weebao weebao merged commit 0b570b5 into main Jun 9, 2025
1 check passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a decorative Japanese dithering effect to the landing page and enhances feature cards with a backdrop blur.

  • Updated the feature-card styling to include a backdrop-blur effect.
  • Injected a fixed container and inline script to load the UnicornStudio dithering animation.
Comments suppressed due to low confidence (3)

src/routes/+page.svelte:228

  • [nitpick] The variable name i is ambiguous; renaming it to something like scriptEl or ditherScript would improve clarity.
var i = document.createElement("script");

src/routes/+page.svelte:229

  • To prevent render-blocking, consider setting i.async = true; (or scriptEl.async = true;) before appending the script element.
(i.src = "https://cdn.jsdelivr.net/gh/hiunicornstudio/unicornstudio.js@v1.4.25/dist/unicornStudio.umd.js"),

src/routes/+page.svelte:229

  • For improved security when loading third-party scripts, consider adding a Subresource Integrity (integrity) attribute and crossOrigin = 'anonymous' on the script element.
(i.src = "https://cdn.jsdelivr.net/gh/hiunicornstudio/unicornstudio.js@v1.4.25/dist/unicornStudio.umd.js"),

<ScrollUpButton screenWidth={1280} />
<div class="fixed -left-4 top-0 -z-[20] opacity-20">
<!-- Cool dithering Japanese effect -->
<div data-us-project="jzsvsRi2fATTRNcOAqWq" class="h-[calc(100dvh+4rem)] w-screen"></div>
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The project ID is hard-coded in the markup; consider extracting it to a configuration constant or environment variable to simplify updates and reduce duplication.

Suggested change
<div data-us-project="jzsvsRi2fATTRNcOAqWq" class="h-[calc(100dvh+4rem)] w-screen"></div>
<div data-us-project={PROJECT_ID} class="h-[calc(100dvh+4rem)] w-screen"></div>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants