Dynamic feature: enable dex files #437
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from PR bazelbuild#271 (bazelbuild/rules_android).
snazhmudinov
force-pushed
the
has_dex_feature
branch
from
5534da2 to
8e1c0b9
Compare
snazhmudinov
changed the title
snazhmudinov
force-pushed
the
has_dex_feature
branch
3 times, most recently
from
9a2b686 to
b398932
Compare
snazhmudinov
force-pushed
the
has_dex_feature
branch
from
b398932 to
2ff9b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded the functionality of feature module to include source code. If feature modules are available, we will run single R8 on both base and feature modules, to ensure consistent dex-ing and obfuscation.
The feature activity can be launched on demand, using the following steps:
cd rules_android/examples/bundle && bazel build //app:assets--bundle=bazel-bin/app/assets_unsigned.aab
--output=assets.apks
--connected-device
Load Feature