Skip to content

Add status code to log message #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanwentzel wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add status code to log message #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8054a15
add status code and error code to log message
Sep 25, 2015
df062d5
fix message format
Sep 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BaseSpace.SDK/Infrastructure/RetryLogic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ private static bool HandleException(string description, ILog logger, bool allowR
{
if (allowRetry)
{
logger.ErrorFormat("Error while {0}, attempt {1}, elapsed {4}ms, retrying in {2} seconds: \r\n{3}", description,
whichAttempt, delay, message, timer.ElapsedMilliseconds);
logger.ErrorFormat("Error while {0}, status code {1}, error code {2}, attempt {3}, elapsed {4}ms, retrying in {5} seconds: \r\n{6}", description,
statusCode, errorCode, whichAttempt, timer.ElapsedMilliseconds, delay, message );
Copy link
Contributor

@greghroberts greghroberts Sep 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorcode have good null checking?

Copy link
Contributor Author

@ryanwentzel ryanwentzel Sep 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code that passes in the errorcode parameter defaults it to an empty string

Thread.Sleep(1000 * delay);
return true;
}
Expand Down