Increase fault tolerance of BridgeReferralFees hooks #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update unit tests to align with recent BridgeReferralFees contract changes: - Change feeBps type from uint16 to uint8 across all tests - Change builder code encoding from bytes32 to string - Update fee calculation to use _safePercent formula - Remove obsolete zero amount revert test (behavior changed) - Update error handling tests for graceful failures Add 20 new test function skeletons with proper NatSpec: - Invalid builder code handling (5 tests) - _safePercent overflow protection (5 tests) - Zero bridged amount behavior (1 test) - BuilderCodes external call failures (2 tests) - Error handling in onDistributeFees (5 tests) - uint8 MAX_FEE_BASIS_POINTS validation (2 tests) All 73 tests passing.
- Add _percent() and _safePercent() helper functions to BridgeReferralFeesTest - Remove 17 unused parameters from 13 test functions - Implement 19 test stubs for new BridgeReferralFees functionality - All 73 BridgeReferralFees tests passing
ilikesymmetry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have to absolutely minimize any possible reverts through execution of
BridgeReferralFees.The following cases have been identified and mitigated:
bridgedAmount - feeAmountunderflow by enforcingMAX_FEE_BASIS_POINTS < 1e4viauint8typefeeAmountcalculation to handle potential overflow caseThe following cases have been identified, but not deemed worth addressing:
tokenargument leading to failingbalanceOfcallstokenthat could violate accounting invariants, making underflow onbridgedAmountcalculation possibleAdditionally, we are removing footguns for the developer by replacing the
bytes32 coderepresentation with the simplerstring code.Asks