fix(windows): repair installer script, enable rustls, and automate releases#87
Open
1001encore wants to merge 5 commits intobartolli:mainfrom
Open
fix(windows): repair installer script, enable rustls, and automate releases#871001encore wants to merge 5 commits intobartolli:mainfrom
1001encore wants to merge 5 commits intobartolli:mainfrom
Conversation
Owner
|
Thanks for the Windows support work - the Cargo.toml and PowerShell fixes are exactly what's needed. A few changes requested:
The git2 platform-specific config and install.ps1 architecture detection are good to merge once these are addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #86
This PR provides a complete fix for Windows support, addressing both the installation script and the build process.
1. Fix Installer Script (
scripts/install.ps1)RuntimeInformation::OSArchitectureis not reliably available.$env:PROCESSOR_ARCHITECTUREcheck.2. Fix Build Dependencies (
Cargo.toml)cargo installwas forcing users to download ~4GB of C++ Build Tools to compile OpenSSL.git2to userustlsand native Windows APIs (Schannel) on Windows targets. This allows pure Rust builds.3. CI Automation (
.github/workflows/release.yml)windows-latestto the release matrix and ensureddist-manifest.jsonis generated. This ensures future releases automatically support the install script.4. Documentation (
README.md)Verification
install.ps1locally; verified it correctly detectswindows-x64and downloads the binary.cargo build --releaseon a Windows machine; confirmed it builds without C++ tools.codanna.exeruns successfully.