Skip to content

fix(windows): repair installer script, enable rustls, and automate releases#87

Open
1001encore wants to merge 5 commits intobartolli:mainfrom
1001encore:feature/windows-support
Open

fix(windows): repair installer script, enable rustls, and automate releases#87
1001encore wants to merge 5 commits intobartolli:mainfrom
1001encore:feature/windows-support

Conversation

@1001encore
Copy link

Description

Closes #86

This PR provides a complete fix for Windows support, addressing both the installation script and the build process.

1. Fix Installer Script (scripts/install.ps1)

  • The script was crashing on Windows PowerShell 5.1 because RuntimeInformation::OSArchitecture is not reliably available.
  • Fix: Switched to standard $env:PROCESSOR_ARCHITECTURE check.

2. Fix Build Dependencies (Cargo.toml)

  • cargo install was forcing users to download ~4GB of C++ Build Tools to compile OpenSSL.
  • Fix: Configured git2 to use rustls and native Windows APIs (Schannel) on Windows targets. This allows pure Rust builds.

3. CI Automation (.github/workflows/release.yml)

  • Added windows-latest to the release matrix and ensured dist-manifest.json is generated. This ensures future releases automatically support the install script.

4. Documentation (README.md)

  • Added the one-line PowerShell install command to the Quick Start section.

Verification

  • Installer: Ran install.ps1 locally; verified it correctly detects windows-x64 and downloads the binary.
  • Build: Ran cargo build --release on a Windows machine; confirmed it builds without C++ tools.
  • Runtime: Verified the resulting codanna.exe runs successfully.

@bartolli
Copy link
Owner

Thanks for the Windows support work - the Cargo.toml and PowerShell fixes are exactly what's needed.

A few changes requested:

  1. Please revert the release.yml changes - I intentionally keep releases manual
  2. The README PowerShell command has markdown link syntax inside the code block - please use the raw URL: irm https://raw.githubusercontent.com/bartolli/codanna/main/scripts/install.ps1 | iex

The git2 platform-specific config and install.ps1 architecture detection are good to merge once these are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Windows installation fails (Installer crash + OpenSSL dependency)

2 participants