Open
Conversation
…E_PORT to be cross-platform compatible feat(local.sh): add wait_for_dfx function to ensure dfx is ready before proceeding with deployments
…atting for better clarity and organization fix: ensure bash is used for local deployment script and add checks for dependencies and canister existence refactor: improve error handling and output in build scripts and canister setup style: apply consistent formatting and spacing across various Rust files for better readability feat: enhance integration testing instructions and clarify setup steps in README fix: correct comments and improve code readability in Rust source files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the shebang lines across all shell scripts in the
canister/scriptsand related directories by replacing#! bashwith#!/bin/bash. Additionally, it improves the platform detection logic inportforward.shto better distinguish native Windows environments from WSL. These changes enhance script compatibility and reliability across different environments.Shell script standardization:
#! bashto#!/bin/bashin all scripts undercanister/scripts/deployments,canister/scripts/upgrades/staging, andcanister/scripts/utils, as well as incanister/setup.sh, to ensure proper interpreter usage and prevent execution issues. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Platform detection improvements:
is_windowsfunction inportforward.shto correctly identify Windows environments and exclude WSL (Windows Subsystem for Linux), improving cross-platform compatibility for port forwarding scripts.