Conversation
sghiassy
commented
Aug 12, 2018
README.md
Outdated
| #### domJSON.toJSON(node, [opts]) ⇒ <code>Object</code> \| <code>string</code> | ||
| Take a DOM node and convert it to simple object literal (or JSON string) with no circular references and no functions or events | ||
|
|
||
| | Param | Type | Description | |
Author
There was a problem hiding this comment.
I have my code editor to prettify on save - hope these changes don't bother.
Owner
There was a problem hiding this comment.
What exactly did you change here? It just seems like you prettified the text and that's it, or am I missing something?
sghiassy
commented
Aug 12, 2018
| var someDOMElement = document.getElementById('sampleId'); | ||
| var jsonOutput = domJSON.toJSON(myDiv); | ||
| let someDOMElement = document.getElementById('sampleId'); | ||
| let jsonOutput = domJSON.toJSON(someDOMElement); |
Author
There was a problem hiding this comment.
The main change of the PR is just to change myDiv to someDOMElement.
Also, changed var to let to encourage "immutability by default". Perhaps too preachy??
Owner
There was a problem hiding this comment.
Would prefer to keep it var since the rest of the code is written in ES5 (this is an ooooold library ;)). But nice catch on the myDiv typo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bug in
README.mdcost me a couple mins; thought I'd post the update to help others.Thanks for the project!