Implemented styling overrides based on active size #34
Conversation
|
Do you need me to do anything to this PR in order to incorporate it into the master? |
src/components/grid/index.js
Outdated
| vertical: { | ||
| flexDirection: 'column', | ||
| alignItems: 'flex-start', | ||
| justifyContent: 'flex-start', |
There was a problem hiding this comment.
Is there specific case for which this is change is required?
As far as I remember, it used to be like that, but we changed it before releasing 1.0, because:
justifyContent: 'flex-start'is the default so there is no need to override italignItems: 'stretch'is the default so we need to override it to prevent elements without specific size from stretching by default (which can still be achieved with<Block size="stretch">)
There was a problem hiding this comment.
I don't remember why off the top of my head, I think it had something to do with react-native-web. I'll try to do some tests before the end of next week and will let you know!
|
Thank you for updating to work with the latest version, this should make it much easier to merge. I am really sorry that I haven't replied before, the everyday job got in the way and then I completely forgot about it. I hope to review this PR once again and merge it when I get a bit more time by the end of this week. I have already planned next week to work through a few other issues so the plan would be to fix all of them and release new versions by the end of next week. |
|
Is there anything else you need me to do to merge this PR? Let me know! |
2 participants
This PR lets us set styling based on the grid's active size. Similar to how you can set smSize, lgSize, etc. now you can do smStyle, lgStyle.
This is pretty cool cause now I can control padding and margins based on the layout.