Skip to content

Added more robust error handling around jar downloads #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kahn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added more robust error handling around jar downloads #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"""
from __future__ import print_function
from setuptools import setup
import os, sys, glob
import os, sys, glob, errno
from setuptools import Command
from setuptools.command.install import install

Expand Down Expand Up @@ -105,11 +105,17 @@ def download_file(self, url, dest):
Downloads a file at the url to the destination.
'''
print('Attempting to retrieve remote jar {url}'.format(url=url))
try:
os.makedirs(self.destdir)
except OSError as exception:
if exception.errno != errno.EEXIST:
raise
try:
urlretrieve(url, dest)
print('Saving {url} -> {dest}'.format(url=url, dest=dest))
except:
except Exception as exception:
print('Failed to retrieve {url}'.format(url=url))
print(exception)
return

def download_files(self):
Expand Down