fix: collect metrics to help analyze performance problems#1124
Draft
fix: collect metrics to help analyze performance problems#1124
Conversation
In multiple places the `SYNTH` span doesn't measure the time to
synthesize the assembly, but rather the time to select stacks from an
already-synthesized assembly.
Presumably this was done in order to avoid duplicating this line:
```ts
const selectStacks = options.stacks ?? ALL_STACKS;
```
Instead, introduce a helper function that gets called from all places,
and centralize the `selectStacks` logic so we don't fear duplication
anymore.
d141182 to
9fa8629
Compare
9fa8629 to
671ef9f
Compare
671ef9f to
063862f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
- Coverage 87.71% 87.34% -0.37%
==========================================
Files 72 74 +2
Lines 10116 10329 +213
Branches 1337 1371 +34
==========================================
+ Hits 8873 9022 +149
- Misses 1217 1279 +62
- Partials 26 28 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes telemetry to help diagnose and address performance problems.
The effective changes are as follows:
For consistency, the same counters changes are being made to
toolkit-lib, even though those counters aren't being consumed by anything.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license