Fix Double Start Round Bug #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging in the replication code we updated our
handleNotarizationMessageto accept messages for previous rounds. This can be dangerous becausehandleNotarizationprocesses the notarization and can callstartRoundindoNotarization. This is problematic because if we have already calledstartRoundwe may run into idompotency issues such as-- calling
monitorProgresstwice on a round, potentially causing us to save many duplicate empty votes & empty notarizations to the wal.-- calling build block twice(not an issue since we guard for this when trying to persist the block, but we do end up building two blocks)