Use readable-stream instead of stream #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taymoork2
force-pushed
the
readable-stream
branch
from
23d06aa to
9f451b5
Compare
|
You can add polyfill manually with webpack. There is no need to change all node packages. |
|
👎 will only increase the dependency tree and ppl will get stuck with a rather old implementation that will never be updated with newer features once a package is no longer maintained. should rather opt to use async iterable instead or something web-ish such as web streams that exist globally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through a webpack v5 upgrade on a repo. With the removal of Automatic nodejs polyfills, i've been seeing stream come up as a issue.
readable-stream is a mirror of node's stream lib from the nodejs team