jws.decode support for encoding option #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary payloads would get mangled due to the unnecessary string conversion, which should go the other way around Fixes: auth0#50
sign: dont convert input buffers to utf8 strings
Just put some curly braces as JS doesn't have such syntax (yet).
Fix typo in code example
deps: replace base64url with inline definition
| var payload = payloadFromJWS(jwsSig); | ||
| var payload = payloadFromJWS(jwsSig, opts.encoding); | ||
| if (header.typ === 'JWT' || opts.json) | ||
| payload = JSON.parse(payload, opts.encoding); |
There was a problem hiding this comment.
Can remove opts.encoding as a second argument to JSON.parse, as this is an argument for the reviver function, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse:
Non-callable values are ignored.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jws.signsupports specifying encoding butjws.decodedoesn't (although thepayloadFromJWSfunction has an unusedencodingparameter). This pull request aims to fix this.