Open
Conversation
In the create_volume() function the following command appears: my @command = ('-t', 'logs', $volume, $quota_kbytes, $mountpoint); These arguments are used with the "volcreate" command. However, the volcreate command defaults to megabytes if the quota units are not specified. Thus sending $quota_kbytes without units causes volcreate to set the quota at 1000 times too large a value. The solution is to change '$quota_kbytes' to '"${quota_kbytes}k"'. Furthermore the function that parses the logs converts the quota number from megabytes into kilobytes. This would be OK except the configuration that is passed to the volume create assumes that the value is in megabytes. The solution is to simply remove this section of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the create_volume() function the following command appears:
my @command = ('-t', 'logs', $volume, $quota_kbytes, $mountpoint);
These arguments are used with the "volcreate" command. However, the volcreate command defaults to megabytes if the quota units are not specified. Thus sending $quota_kbytes without units causes volcreate to set the quota at 1000 times too large a value. The solution is to change '$quota_kbytes' to '"${quota_kbytes}k"'.
Furthermore the function that parses the logs converts the quota number from megabytes into kilobytes. This would be OK except the configuration that is passed to the volume create assumes that the value is in megabytes. The solution is to simply remove this section of code.