[:httpd] Fix HTTP large request + response handling #14
+143
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harmon25
changed the title
harmon25
changed the title
UncleGrumpy
requested changes
Dec 16, 2025
| {more, Packet}; | ||
| {_Pos, _Len} -> | ||
| try | ||
| {ok, parse_http_request(binary_to_list(Packet))} |
Collaborator
There was a problem hiding this comment.
This line has a syntax error. parse_http_request/1 returns a map().
Author
There was a problem hiding this comment.
Hmm not sure about this one - it does return a map.
Collaborator
|
Also, we don't have any CI checks for this repo yet, but would you please signoff all of your commits? |
Author
|
I could squash + sign when we are done with review? i can also open another PR with the commits signed |
Collaborator
Since this PR is focused on just the one bug fix, squash and sign will be great. No need to open a separate PR. I would have helped you get previous commits signed if that was necessary. ;-) |
…te management Signed-off-by: harmon25 <dougwright1@gmail.com>
Signed-off-by: harmon25 <dougwright1@gmail.com>
Signed-off-by: harmon25 <dougwright1@gmail.com>
Author
|
OK i signed off with a force push! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot assisted - might not be cleanest implementation of a fix for the issue, but it does the trick.