Refactor of utility C code for less duplication #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 93.09% 95.09% +2.00%
==========================================
Files 7 6 -1
Lines 782 836 +54
Branches 12 0 -12
==========================================
+ Hits 728 795 +67
+ Misses 54 41 -13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
astrofrog
force-pushed
the
feature/median-refactor
branch
from
0f2f955 to
5dcc79c
Compare
Member
|
I took the liberty of rebasing this - took a little while, but think all the conflicts should be resolved. |
astrofrog
force-pushed
the
feature/median-refactor
branch
from
5dcc79c to
607d2a0
Compare
saimn
force-pushed
the
feature/median-refactor
branch
from
607d2a0 to
818b058
Compare
saimn
reviewed
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of code duplication in the C code for medianing and dilating images. I have removed as much as possible in hopes of making it easier to update how edges are handled in the future as discussed in #38 . Note this is expected to be merged after #74.