Skip to content

Pass loop attribute to asyncio.ensure_future #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-k wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass loop attribute to asyncio.ensure_future #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mode/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,10 @@ def execute_from_commandline(self) -> NoReturn:
self._starting_fut = None
with exiting(file=self.stderr):
try:
self._starting_fut = asyncio.ensure_future(self.start())
self._starting_fut = asyncio.ensure_future(
self.start(),
loop=self.loop,
)
self.loop.run_until_complete(self._starting_fut)
except asyncio.CancelledError:
pass
Expand Down
2 changes: 1 addition & 1 deletion t/unit/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def test_execute_from_commandline(self, worker):
worker.execute_from_commandline()
assert excinfo.value.code == 0
assert worker._starting_fut is ensure_future.return_value
ensure_future.assert_called_once_with(worker.start.return_value)
ensure_future.assert_called_once_with(worker.start.return_value, worker.loop)
worker.stop_and_shutdown.assert_called_once_with()

def test_execute_from_commandline__MemoryError(self, worker):
Expand Down