Allow developer to set a custom web socket url#111
Open
FortuneN wants to merge 6 commits intoashmind:mainfrom
Open
Allow developer to set a custom web socket url#111FortuneN wants to merge 6 commits intoashmind:mainfrom
FortuneN wants to merge 6 commits intoashmind:mainfrom
Conversation
- Default behavior does not break current usages - Default behavior allows more usages whose URL ends with "/mirrorsharp" - When a WebSocketUrl is set, that is used - We are lenient with the case of the URL - We are lenient with leading or following spaces
Owner
|
Thanks for this! I think the goal definitely makes sense. I would be keen to investigate a bit further on the new endpoint routing -- seems like something we could use here? Not sure yet, haven't tried it myself. |
Summary path change -> the 'wss:/' part is not necessary
Owner
|
I have investigated the endpoint routing a bit, and I think we don't have to handle the URL manually. What we could do instead is:
app.Map("/mirrorsharp", app => app.UseMirrorSharp());Obviously we want people to avoid mistakes, so I would actually obsolete
app.UseEndpoints(endpoints =>
{
endpoints.Map("/mirrorsharp", endpoints.CreateApplicationBuilder()
.UseMirrorSharp()
.Build());
});This is obviously too verbose, so providing another So, in summary, I suggest the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ISSUE] #110