fix condition of Add in Linked List#21
Open
Mohammadjafari80 wants to merge 1 commit intoarnauddri:masterfrom
Open
fix condition of Add in Linked List#21Mohammadjafari80 wants to merge 1 commit intoarnauddri:masterfrom
Mohammadjafari80 wants to merge 1 commit intoarnauddri:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a tiny problem with the condition. when the index is equal to the length of the list we must append it to the tail not when it's equal to length - 1. The reason is that we start counting from zero therefore we should have at least length + 1 spot for inserting a node( counting length from zero). I guess you didn't notice because the tests actually didn't cover it.