Fix badge trimming of second icon #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've tried your solution, but in this case, is not working as expected: |
Author
|
Yes, proceeding this way distorts the shape of center button shadow. This is beneficial if one is not using that shadow. On investigating the code of main repository I identified that the width of second and third element (message and search) in above screenshot has been calculated with the assumption that center button doesn't have any left , right margin/padding. This is why when we show the badge to 2nd menu item. It gets trimmed on rendering. |
Contributor
|
Fixed here: #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add 4 icons in bottom navigation and set badges on second icon (which is left to center icon), the badge text gets trim due to the padding assigned to center button. This update fixes that issue.
This update also adds another screen on sample project to demonstrate how badge can be assigned to the icons.
Irrespective of interest Gradle has been updated as well to version 4.1 to make the compilation successful.
Please merge to main repository and update the dependency version.