Move play-tagged options into common_loop_options#68
Open
Splendide-Imaginarius wants to merge 1 commit intoarkrow:masterfrom
Open
Move play-tagged options into common_loop_options#68Splendide-Imaginarius wants to merge 1 commit intoarkrow:masterfrom
play-tagged options into common_loop_options#68Splendide-Imaginarius wants to merge 1 commit intoarkrow:masterfrom
Conversation
Remove the play-tagged command since it's now redundant. Fixes arkrow#67
Contributor
Author
|
This turned out to be much simpler than I was anticipating. Everything seems to work fine in my testing, but please do give it a look-over in case I missed some edge case. Hopefully the CLI compatibility break isn't a problem... I think this interface is a lot cleaner than the status quo, and I don't think it should be problematic for scripters to adapt to it, but it is admittedly still a backwards-incompatible change. |
Contributor
Author
|
@arkrow Any idea when you might be able to review this? |
Contributor
Author
|
@arkrow Status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
play-taggedcommand since it's now redundant.Fixes #67