Open
Conversation
Contributor
|
Are we not doing |
Contributor
Author
|
I was hoping to avoid having to support Arguably, just to check that a JCR syntax is valid you might have a validate that an object referenced by Do you think we should support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the parser and parser tests to support @{exclude-min}, @{exclude-max} and @{default ???}.
NOTE WELL!...
I haven't updated the validation side of things. evaluate_value_rules.rb:53 and evaluate_value_rules.rb:94 look relevant, but I think you also do some rationalisation of specified annotations before the code gets to that stage (e.g. evaluate-rules.rb:223). Rather than wade in and risk causing more trouble than good, I decided to leave that to you.