Fixed readme, and fixed the flag error, of - to _#117
Open
samholt wants to merge 1 commit intoargman:masterfrom
Open
Fixed readme, and fixed the flag error, of - to _#117samholt wants to merge 1 commit intoargman:masterfrom
samholt wants to merge 1 commit intoargman:masterfrom
Conversation
Collaborator
|
Why did you change ‘-’ to '_'? |
|
@zxytim because when '-' is used, the demo program will fail as (when the dubug mode of flask is on it will show such traceback message) it seems in somewhere the program needs "checkpoint_path" not "checkpoint-path". And after I replace "checkpoint-path" in run_demo_server.py as "checkpoint_path", the error is gone and program works. so not only the readme needs modification, "run_demo_server.py" needs it too. |
gabrielziegler3
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed flag naming convention, that causes python to throw an error when running. See below from a hyphen - to underscore _.