Pin the major platform/core version for updates #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoCrobu
force-pushed
the
issue_738
branch
from
8b0899e to
98440c3
Compare
Xayton
reviewed
Dec 19, 2025
lucarin91
reviewed
Dec 22, 2025
| Name: "arduino:zephyr", | ||
| FromVersion: platformSummary.GetInstalledVersion(), | ||
| ToVersion: platformSummary.GetLatestVersion(), | ||
| ToVersion: bestVersion, |
Contributor
There was a problem hiding this comment.
it doesn't seem that this ToVersion is used in the upgrade function, so I think we always upgrade to the latest version
| if err != nil { | ||
| return Configuration{}, fmt.Errorf("invalid LIBRARIES_API_URL: %w", err) | ||
| } | ||
| maxVersionStr := os.Getenv("ARDUINO_APP_CLI__MAX_UPDATE_MAJOR_VERSION") |
Contributor
There was a problem hiding this comment.
I would make this a version constraint string, parsable with relaxed-semver https://pkg.go.dev/go.bug.st/relaxed-semver#readme-version-constraints. For instance, the default value should be <1.0.0, which will match anything less that isn't 1.0.0
Comment on lines
+148
to
+183
| func findBestCandidate(installedStr string, availableVersions []string, maxMajorConfig int) (string, error) { | ||
| installedV, err := semver.NewVersion(installedStr) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| maxMajor := uint64(maxMajorConfig) | ||
| if maxMajorConfig <= 0 { | ||
| maxMajor = installedV.Major() | ||
| } | ||
|
|
||
| var bestUpdateV *semver.Version | ||
|
|
||
| for _, vStr := range availableVersions { | ||
| candidateV, err := semver.NewVersion(vStr) | ||
| if err != nil { | ||
| continue | ||
| } | ||
|
|
||
| if candidateV.Major() > maxMajor { | ||
| continue | ||
| } | ||
|
|
||
| if !candidateV.GreaterThan(installedV) { | ||
| continue | ||
| } | ||
| if bestUpdateV == nil || candidateV.GreaterThan(bestUpdateV) { | ||
| bestUpdateV = candidateV | ||
| } | ||
| } | ||
|
|
||
| if bestUpdateV == nil { | ||
| return "", nil | ||
| } | ||
| return bestUpdateV.Original(), nil | ||
| } |
Contributor
There was a problem hiding this comment.
You can use the constraint in a way like this
Suggested change
| func findBestCandidate(installedStr string, availableVersions []string, maxMajorConfig int) (string, error) { | |
| installedV, err := semver.NewVersion(installedStr) | |
| if err != nil { | |
| return "", err | |
| } | |
| maxMajor := uint64(maxMajorConfig) | |
| if maxMajorConfig <= 0 { | |
| maxMajor = installedV.Major() | |
| } | |
| var bestUpdateV *semver.Version | |
| for _, vStr := range availableVersions { | |
| candidateV, err := semver.NewVersion(vStr) | |
| if err != nil { | |
| continue | |
| } | |
| if candidateV.Major() > maxMajor { | |
| continue | |
| } | |
| if !candidateV.GreaterThan(installedV) { | |
| continue | |
| } | |
| if bestUpdateV == nil || candidateV.GreaterThan(bestUpdateV) { | |
| bestUpdateV = candidateV | |
| } | |
| } | |
| if bestUpdateV == nil { | |
| return "", nil | |
| } | |
| return bestUpdateV.Original(), nil | |
| } | |
| func findBestCandidate(availableVersions []string, constraint semver.Constraint) (string, error) { | |
| releases := make([]*semver.Version, 0, len(availableVersions)) | |
| for _, verStr := range availableVersions{ | |
| if ver, err := semver.NewVersion(installedStr); err == nil { | |
| if constraint.Match(ver){ | |
| releases = append(releases, ver) | |
| } | |
| } | |
| } | |
| if len(releases) == 0 { | |
| return "", nil | |
| } | |
| slices.SortStableFunc(releases, func(a, b *semver.Version) int { | |
| return a.Compare(b) | |
| }) | |
| return releases[len(releases)-1].String(), nil | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #738
The logic that updates the platform should make sure we do not upgrade above the 1.x.x release.
In other words there should be a variable specifying the maximum major version that will be reported as an update.
This is to avoid auto-updating to a breaking change.>
Change description
Additional Notes
Reviewer checklist
main.