Added constants to fully comply to standard websocket#19
Added constants to fully comply to standard websocket#19hktonylee wants to merge 1 commit intoappuri:masterfrom
Conversation
|
I really don't want to maintain a typescript definition. Moreover it shouldn't matter, as one place may instantiate it knowing it is a |
|
That's fine to skip the Typescript definition. But the standard web socket has constants in the prototype. That means anyone can access the constants in both In order to make it fully transparent, it is necessary to add the constants. |
|
Oh I was not aware they were on the prototype too. If.you can scope the PR down to that we can take it. |
|
I have force-updated the branch. Please check ;-) |
No description provided.