Add support for Windows #567
Open
+138
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation of NIOSSL on Windows Note: This code adds some things we might not want to keep around. - OPENSSL_NO_ASM flag which I neededto get it to work - Windows directory listing using FindFirstFileA (not properly tested) - mlock -> VirtualLock on Windows (doesn't yet check if locking was successful)
Author
|
Still needs to set up Windows CI, but if possible I'd like to ensure the tests still succeed on existing platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation of NIOSSL on Windows
Note: This code adds some things we might not want to keep around.