fix(appium): Inject symlinks for all installed extensions#21664
Merged
mykola-mokhnach merged 4 commits intoappium:masterfrom Oct 20, 2025
Merged
fix(appium): Inject symlinks for all installed extensions#21664mykola-mokhnach merged 4 commits intoappium:masterfrom
mykola-mokhnach merged 4 commits intoappium:masterfrom
Conversation
eglitise
reviewed
Oct 20, 2025
| // We also inject the symlink into other installed extensions' node_modules folders | ||
| // as these might be cleaned up unexpectedly by npm | ||
| // (see https://github.com/appium/python-client/pull/1177#issuecomment-3419826643). | ||
| await B.all(symlinkInjectionPromises); |
Collaborator
There was a problem hiding this comment.
We can probably use the native Promise.all instead
Collaborator
Author
There was a problem hiding this comment.
both do the same thing. Changed to Promise
KazuCocoa
reviewed
Oct 20, 2025
Member
KazuCocoa
left a comment
KazuCocoa
left a comment
There was a problem hiding this comment.
This worked for update command such as appium driver update xcuitest. Then, non-symlink modules got proper appium's ones. Once I copied the same thing in the removed await injectAppiumSymlink.bind(this)(path.join(installPath, 'node_modules')); place as my comment, it helped keep the behavior for the install as well
Comment on lines
457
to
459
| // After the extension is installed, we try to inject the appium module symlink | ||
| // into the extension's node_modules folder if it is not there yet. | ||
| await injectAppiumSymlink.bind(this)(path.join(installPath, 'node_modules')); |
Member
There was a problem hiding this comment.
const symlinkInjectionPromises = _.uniq([
...Object.values(this.config.installedExtensions).map(({installPath}) => installPath),
installPath,
]).map((installPath) => injectAppiumSymlink.bind(this)(path.join(installPath, 'node_modules')));
await B.all(symlinkInjectionPromises);
Member
There was a problem hiding this comment.
e.g.
The ======== log was a log I have added before symlinkInjectionPromises to tell these changes passed explicitly.
kazu $ appium driver install xcuitest
✔ Checking if 'appium-xcuitest-driver' is compatible
✔ Installing 'xcuitest'
⚠ [debug] ======== log
ℹ Driver xcuitest@10.2.2 successfully installed
- automationName: XCUITest
- platformNames: ["iOS","tvOS"]
kazu $ ls -all ~/.appium/node_modules/appium-xcuitest-driver/node_modules | grep 'appium'
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 @appium
lrwxr-xr-x@ 1 kazu staff 63 Oct 19 23:44 appium -> /Users/kazu/.nvm/versions/node/v22.18.0/lib/node_modules/appium
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-idb
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-ios-device
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-ios-remotexpc
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-ios-simulator
drwxr-xr-x@ 11 kazu staff 352 Oct 19 23:44 appium-ios-tuntap
drwxr-xr-x@ 11 kazu staff 352 Oct 19 23:44 appium-remote-debugger
drwxr-xr-x@ 16 kazu staff 512 Oct 19 23:44 appium-webdriveragent
drwxr-xr-x@ 8 kazu staff 256 Oct 19 23:44 appium-xcode
kazu $ appium driver install uiautomator2
✔ Checking if 'appium-uiautomator2-driver' is compatible
✔ Installing 'uiautomator2'
⚠ [debug] ======== log
ℹ Driver uiautomator2@5.0.5 successfully installed
- automationName: UiAutomator2
- platformNames: ["Android"]
kazu $ ls -all ~/.appium/node_modules/appium-xcuitest-driver/node_modules | grep 'appium'
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 @appium
lrwxr-xr-x@ 1 kazu staff 63 Oct 19 23:47 appium -> /Users/kazu/.nvm/versions/node/v22.18.0/lib/node_modules/appium
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-idb
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-ios-device
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-ios-remotexpc
drwxr-xr-x@ 9 kazu staff 288 Oct 19 23:44 appium-ios-simulator
drwxr-xr-x@ 11 kazu staff 352 Oct 19 23:44 appium-ios-tuntap
drwxr-xr-x@ 11 kazu staff 352 Oct 19 23:44 appium-remote-debugger
drwxr-xr-x@ 16 kazu staff 512 Oct 19 23:44 appium-webdriveragent
drwxr-xr-x@ 8 kazu staff 256 Oct 19 23:44 appium-xcode
Current PR change (without my comment) worked this behavior for update
Collaborator
Author
There was a problem hiding this comment.
👍
Moved it back to installViaNpm
KazuCocoa
approved these changes
Oct 20, 2025
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses appium/python-client#1177 (comment)