feat: Add includeHittableInSource setting for including real hittable attribute in XML source #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute in XML source
|
Please also check and update failing unit tests |
… method, since the hittable attribute setting has been moved to another location
ikharebashviliGD
changed the title
|
Please do not forget to add the new setting into https://github.com/appium/appium-xcuitest-driver/blob/master/docs/reference/settings.md after this PR is published |
KazuCocoa
reviewed
Jun 3, 2025
KazuCocoa
approved these changes
Jun 3, 2025
Author
|
@mykola-mokhnach @KazuCocoa |
mykola-mokhnach
approved these changes
Jun 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
## [9.11.0](v9.10.1...v9.11.0) (2025-06-03) ### Features * Add includeHittableInSource setting for including real hittable attribute in XML source ([#1026](#1026)) ([0fa4e74](0fa4e74))
|
🎉 This PR is included in version 9.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
KazuCocoa
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces support for a new
includeHittableInSourcesetting.isHittablevalues)hittableattribute in the resulting XML with accurate dataBy default, the attribute is excluded due to performance cost and unreliable values from non-native snapshots.
Why not JSON?
Previously, I attempted to expose
isHittablein the JSON response as part of [this PR], but due to snapshot limitations and performance concerns, it was not feasible. This XML-based solution respects performance by remaining opt-in via a dedicated flag.