[#2353] Improvement: Fix the warning: unchecked method invocation: method sendCachedBuffer in class RMRecordsReader.RecordsCombiner is applied to given types#2358
Merged
roryqi merged 4 commits intoapache:masterfrom Feb 17, 2025
Conversation
cchung100m
changed the title
sendCachedBuffer in class RMRecordsReader.RecordsCombiner is applied to given typessendCachedBuffer in class RMRecordsReader.RecordsCombiner is applied to given types
cchung100m
force-pushed
the
issue-2353
branch
from
0ebb3bd to
934a972
Compare
cchung100m
force-pushed
the
issue-2353
branch
from
6beb99a to
409d462
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
============================================
+ Coverage 44.18% 51.89% +7.70%
- Complexity 0 3445 +3445
============================================
Files 21 529 +508
Lines 2553 28488 +25935
Branches 0 2677 +2677
============================================
+ Hits 1128 14783 +13655
- Misses 1352 12745 +11393
- Partials 73 960 +887 ☔ View full report in Codecov by Sentry. |
…on: method sendCachedBuffer in class RMRecordsReader.RecordsCombiner is applied to given types
…on: method sendCachedBuffer in class RMRecordsReader.RecordsCombiner is applied to given types
cchung100m
force-pushed
the
issue-2353
branch
from
82d0c4e to
3e62182
Compare
…on: method sendCachedBuffer in class RMRecordsReader.RecordsCombiner is applied to given types
cchung100m
force-pushed
the
issue-2353
branch
from
e57124f to
bc10eb5
Compare
roryqi
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the warning: unchecked method invocation: method
sendCachedBufferin classRMRecordsReader.RecordsCombineris applied to given typesWhy are the changes needed?
Fix: #2353
Does this PR introduce any user-facing change?
No.
How was this patch tested?
current UT