Skip to content

[#2356] Improvement: Fix the warning: unchecked call to put(E) as a member of the raw type RMRecordsReader.Queue#2357

Merged
roryqi merged 1 commit intoapache:masterfrom
cchung100m:issue-2356
Feb 13, 2025
Merged

[#2356] Improvement: Fix the warning: unchecked call to put(E) as a member of the raw type RMRecordsReader.Queue#2357
roryqi merged 1 commit intoapache:masterfrom
cchung100m:issue-2356

Conversation

@cchung100m
Copy link
Collaborator

@cchung100m cchung100m commented Feb 2, 2025

What changes were proposed in this pull request?

Fix the warning: unchecked call to put(E) as a member of the raw type RMRecordsReader.Queue

Why are the changes needed?

Fix: #2356

Does this PR introduce any user-facing change?

No.

How was this patch tested?

current UT
image

@cchung100m
Copy link
Collaborator Author

Hi @jerqi Can you help me to re-run the job? Thank you. 😄

@cchung100m cchung100m changed the title [#2356] Improvement: Fix the warning: unchecked call to put(E) as a member of the raw type RMRecordsReader.Queue [#2356] Improvement: Fix the warning: unchecked call to put(E) as a member of the raw type RMRecordsReader.Queue Feb 8, 2025
@cchung100m cchung100m self-assigned this Feb 8, 2025
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this pull request Feb 9, 2025
@github-actions
Copy link

github-actions bot commented Feb 9, 2025

Test Results

 2 996 files  ±0   2 996 suites  ±0   6h 30m 43s ⏱️ + 1m 56s
 1 105 tests ±0   1 103 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 849 runs  ±0  13 819 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 405149c. ± Comparison against base commit 608471a.

♻️ This comment has been updated with latest results.

cchung100m added a commit to cchung100m/incubator-uniffle that referenced this pull request Feb 11, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.44%. Comparing base (81e00be) to head (a69dc3e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2357      +/-   ##
============================================
+ Coverage     44.18%   51.44%   +7.26%     
- Complexity        0     3026    +3026     
============================================
  Files            21      478     +457     
  Lines          2553    23085   +20532     
  Branches          0     2129    +2129     
============================================
+ Hits           1128    11877   +10749     
- Misses         1352    10463    +9111     
- Partials         73      745     +672     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…as a member of the raw type RMRecordsReader.Queue
@cchung100m cchung100m marked this pull request as ready for review February 11, 2025 13:48
@cchung100m cchung100m requested review from roryqi and zuston February 11, 2025 13:49
Copy link
Contributor

@roryqi roryqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@roryqi roryqi merged commit 124a901 into apache:master Feb 13, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Fix the warning: unchecked call to put(E) as a member of the raw type RMRecordsReader.Queue

3 participants

Comments