[GH-2396] Making splitting polygon by line robust by removing the computation of line-polygon intersection #2598
+43
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. ClosesGeometrySplitter.splitreturns empty geometry #2396What changes were proposed in this PR?
This patch fixes splitting a polygon using linestring by porting the corresponding logic from PostGIS. Relevant PostGIS code: https://github.com/postgis/postgis/blob/3.6.1/liblwgeom/lwgeom_geos_split.c#L349-L491
How was this patch tested?
Added the case mentioned in the issue as a unit test and pass it.
Did this PR include necessary documentation updates?