HBASE-29526 Dynamic configuration not working for coprocessor #7514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Jaehui-Lee
force-pushed
the
HBASE-29526-master
branch
from
6eee0d3 to
c8a4c3e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Jaehui-Lee
force-pushed
the
HBASE-29526-master
branch
from
c8a4c3e to
fe1f2af
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
taklwu
reviewed
Dec 11, 2025
Contributor
taklwu
left a comment
taklwu
left a comment
There was a problem hiding this comment.
you are right about the updateConfiguration() has been updated so that getConf() has been updated. thanks for spotting this bug.
Comment on lines
58
to
74
| Set<String> currentlyLoaded = coprocessorHost.getCoprocessorClassNames(); | ||
|
|
||
| // Get coprocessor class names from configuration | ||
| Set<String> configuredClasses = new HashSet<>(); | ||
| for (String key : configurationKey) { | ||
| String[] classes = conf.getStrings(key); | ||
| if (classes != null) { | ||
| for (String className : classes) { | ||
| // Handle the className|priority|path format | ||
| String[] classNameToken = className.split("\\|"); | ||
| String actualClassName = classNameToken[0].trim(); | ||
| if (!Strings.isNullOrEmpty(actualClassName)) { | ||
| configuredClasses.add(actualClassName); | ||
| } | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
this made me rethink about the configuration change detection cannot handle path reload, and even if we can detect changes for classname and priority.
So, can you update a note/comment in the function checkConfigurationChange, that priority and path changes are not supported with the same classname once it's loaded?
Comment on lines
85
to
86
| !conf.getBoolean(CoprocessorHost.COPROCESSORS_ENABLED_CONF_KEY, | ||
| CoprocessorHost.DEFAULT_COPROCESSORS_ENABLED) |
Contributor
There was a problem hiding this comment.
maybe we should move this COPROCESSORS_ENABLED_CONF_KEY check to the top of checkConfigurationChange
…rocessor enabled check to top
Contributor
Author
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
taklwu
approved these changes
Dec 12, 2025
Contributor
taklwu
left a comment
taklwu
left a comment
There was a problem hiding this comment.
thanks for fixing the bug!
Contributor
|
@Jaehui-Lee can you open PRs for branch-3, branch-2, branch-2.6 as well ? |
Contributor
Author
|
I opened PRs for branch-3, branch-2, branch-2.6
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-29526