Skip to content

Conversation

@jcongithub
Copy link

@jcongithub jcongithub commented Nov 27, 2025

UnloadRegions log message uses the hostname to show where regions are unloading from. When a host runs multiple region servers, the hostname in the log message alone is insufficient to identify which specific region server is unloading regions.

This PR has the change to use ServerName in the log, making it easier to distinguish between region servers on the same host similar to loadRegions log message.

This PR also fixes a log statement

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@chandrasekhar-188k chandrasekhar-188k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PDavid
Copy link
Contributor

PDavid commented Dec 10, 2025

Hi @jcongithub,

Thanks for your contribution.
Can you please add the Jira ticket ID to the commit message - e.g. use the commit message format documented here:
https://hbase.apache.org/book.html#hbase.commit.msg.format

Please also update the PR title to start with the Jira ticket ID.

@jcongithub jcongithub changed the title Use ServerName instead of hostname in unloadRegions log message HBASE-29733 Use ServerName instead of hostname in unloadRegions log message Dec 11, 2025
@jcongithub
Copy link
Author

Thanks @PDavid
Updated

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 5s Docker failed to build run-specific yetus/hbase:tp-151}.
Subsystem Report/Notes
GITHUB PR #7487
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/3/console
versions git=2.17.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 4m 1s master passed
+1 💚 compile 3m 22s master passed
+1 💚 checkstyle 1m 1s master passed
+1 💚 spotbugs 1m 41s master passed
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 57s the patch passed
+1 💚 compile 3m 19s the patch passed
+1 💚 javac 3m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 0s the patch passed
+1 💚 spotbugs 1m 40s the patch passed
+1 💚 hadoopcheck 11m 25s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
40m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7487
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 61b7dade46ee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3b4b0cb
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7487/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Kota-SH Kota-SH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants