-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29733 Use ServerName instead of hostname in unloadRegions log message #7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chandrasekhar-188k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @jcongithub, Thanks for your contribution. Please also update the PR title to start with the Jira ticket ID. |
b922d09 to
3b4b0cb
Compare
|
Thanks @PDavid |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Kota-SH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
UnloadRegions log message uses the hostname to show where regions are unloading from. When a host runs multiple region servers, the hostname in the log message alone is insufficient to identify which specific region server is unloading regions.
This PR has the change to use ServerName in the log, making it easier to distinguish between region servers on the same host similar to loadRegions log message.
This PR also fixes a log statement