[FLINK-38757][runtime] Introduce the base class for application #27306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zhuzhurk
reviewed
Dec 10, 2025
| FAILED(true), | ||
|
|
||
| /** The application is being cancelled. */ | ||
| CANCELLING(false), |
Contributor
There was a problem hiding this comment.
It's better to name it as CANCELING to be aligned with CANCELED.
We do not need to follow the inconsistency in JobStatus.
| import java.util.concurrent.Executor; | ||
|
|
||
| /** Base class for all applications. */ | ||
| @Internal |
Contributor
There was a problem hiding this comment.
This annotation is not needed because classes in flink-runtime module are internal by default.
| * <p>The returned CompletableFuture indicates that the execution request has been accepted and | ||
| * the application transitions to RUNNING state. | ||
| * | ||
| * <p><b>Note:</b> This method must be called on the main thread. |
Contributor
There was a problem hiding this comment.
on -> in
You mean the main thread of which component?
| * | ||
| * <p>This method is not thread-safe and should not be called concurrently. | ||
| */ | ||
| public boolean addJob(JobID jobId) { |
Contributor
There was a problem hiding this comment.
It's not required to be called in the main-thread? If not, how to ensure the state to be synchronized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request introduces the base class for application that supports state transitions and job bookkeeping.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation